The Syrians - Read the Edomites, as in marginal references (compare Psalm 60:1-12 title), and as the context 2-Samuel 8:14 requires. For a further account of this war of extermination with Edom, see 1-Kings 11:15-16. The war with Edom was of some duration, not without serious reverses and dangers to the Israelites (2-Samuel 8:2 note). The different accounts probably relate to different parts of the campaign.

David gat him a name - Became a very celebrated and eminent man. The Targum has it, David collected troops; namely, to recruit his army when he returned from smiting the Syrians. His many battles had no doubt greatly thinned his army.
The valley of salt - Supposed to be a large plain abounding in this mineral, about a league from the city of Palmyra or Tadmor in the wilderness.

And David gat him a name,.... Fame and reputation in the several nations of the world for valour and courage, for the many and signal victories that he obtained; the Jewish writers generally refer this to his humanity in burying the dead bodies of his enemies slain in war, which gained him great esteem among all, and even his very enemies; but nothing of that kind is pointed at here, but his conquests: or "he made himself a name"; erected a triumphal arch (b) in memory of his victories:
when he returned from smiting of the Syrians in the valley of salt,
being eighteen thousand men; in the relation of this fact in different places some difficulties arise, both as to the people smitten, and their numbers, and by whom; in this place they are said to be Syrians, but in 1-Chronicles 18:12, and in the title of Psalm 60:1, which was composed on account of these victories, they are called Edomites, and said to be of Edom; which may be reconciled by observing, that the Syrians and Edomites were confederates in this war; and that whereas the latter were auxiliaries to the former, the whole body of the army might be called Syrians, of which twenty two thousand were slain that were properly Syrians, and eighteen thousand Edomites, in all forty thousand; which was a very great slaughter: or the sense is, that when he had smitten the twenty two thousand Syrians, and was upon the return, he met with a body of Edomites, who came to the assistance of the Syrians, and he slew eighteen thousand of them; and the Jews say, as Jarchi observes, there were two battles; and if so, this would remove all the difficulties started; as for the numbers slain, here eighteen thousand, and Psalm 60:1, twelve thousand, it is reconciled by observing, that Abishai first began the attack upon the Edomites, and slew six thousand of them; and then Joab fell upon them, and slew twelve thousand more, in all eighteen thousand; in 1-Chronicles 18:12, this slaughter is ascribed to Abishai, because he began it, even the whole number; and in Psalm 60:1, to Joab, the twelve thousand slain by him, who seconded Abishai; and the whole is here attributed to David, because he was king, under whom Abishai and Joab served as generals: and no less difficult is it to ascertain the place where this slaughter was made, called "the valley of salt": it seems by our text that it was in Syria, but in other places as if it was in Edom; see 2-Kings 14:7; but in Edom itself is no such valley to be found, though there is in Syria; one traveller (c) tells us, that in the way from Aleppo to the banks of Euphrates are many villages, among which is one of note, called Tedith, famous for a synod held here by the Jews, in the year from the creation 3498, of which Ezra was the scribe; when were placed the books of the Old Testament in the order in which they now are; and near this town, he says, is the valley of salt, memorable for the victory here recorded: others say (d) about three or four hours' journey from Aleppo is the valley of salt, near which is a salt spring, whose waters running over the place leave, when dried by the sun, a great quantity of excellent salt; this salt is thrown together in the Gabboul, or salt house; but by others (e) we are informed, that near about an hour's distance from the city of Tadmor, see 1-Kings 9:18 2-Chronicles 8:3, is to be seen a large valley of salt, affording great quantities thereof; and it is thought that this is more probably the valley of salt mentioned here, than another which lies about four hours from Aleppo, and has sometimes passed for it; and which the above accounts show: but a modern writer (f), in his account of Palmyra, the same with Tadmor, speaks of a great plain, all covered with salt, from whence the whole country round is supplied. This plain is about a league from Palmyra, and extends itself towards the eastern part of Idumea (or Edom) the capital city of which was Bozra; and indeed this valley being both in Syria, and reaching to the borders of Edom, bids fair to be the valley here spoken of.
(b) So Hieron. Trad. Hebrews. in 2 Reg. fol. 78. D. (c) Cartwright's Preacher's Travels, p. 11. (d) Egmont and Heyman's Travels, vol. 2. p. 347. (e) See Lowthorp's Philosophical Transactions abridged, vol. 3. p. 504. (f) Halifax apud Calmet's Dictionary in the Word "Salt".

David gat him a name when he returned from smiting of the Syrians--Instead of Syrians, the Septuagint version reads "Edomites," which is the true reading, as is evident from 2-Samuel 8:14. This conquest, made by the army of David, was due to the skilful generalship and gallantry of Abishai and Joab. (1-Chronicles 18:12; compare Psalm 60:1, title.) The valley was the ravine of salt (the Ghor), adjoining the Salt Mountain, at the southwestern extremity of the Dead Sea, separating the ancient territories of Judah and Edom [ROBINSON].

"And David made (himself) a name, when he returned from smiting (i.e., from the defeat of) Aram, (and smote Edom) in the valley of Salt, eighteen thousand men." The words enclosed in brackets are wanting in the Masoretic text as it has come down to us, and must have fallen out from a mistake of the copyist, whose eye strayed from את־ארם to את־אדום; for though the text is not "utterly unintelligible" without these words, since the passage might be rendered "after he had smitten Aram in the valley of Salt eighteen thousand men," yet this would be decidedly incorrect, as the Aramaeans were not smitten in the valley of Salt, but partly at Medeba (1-Chronicles 19:7) and Helam (2-Samuel 10:17), and partly in their own land, which was very far away from the Salt valley. Moreover, the difficulty presented by the text cannot be removed, as Movers supposes, by changing את־ארם (Syria) into את־אדום (Edom), as the expression בּשׁבו ("when he returned") would still be unexplained. The facts were probably these: Whilst David, or rather Israel, was entangled in the war with the Ammonites and Aramaeans, the Edomites seized upon the opportunity, which appeared to them a very favourable one, to invade the land of Israel, and advanced as far as the southern extremity of the Dead Sea. As soon, therefore, as the Aramaeans were defeated and subjugated, and the Israelitish army had returned from this war, David ordered it to march against the Edomites, and defeated them in the valley of Salt. This valley cannot have been any other than the Ghor adjoining the Salt mountain on the south of the Dead Sea, which really separates the ancient territories of Judah and Edom (Robinson, Pal. ii. 483). There Amaziah also smote the Edomites at a later period (2-Kings 14:7). We gather more concerning this war of David from the text of the Chronicles (2-Samuel 8:12) taken in connection with 1-Kings 11:15-16, and Psalm 60:2. According to the Chronicles, it was Abishai the son of Zeruiah who smote the Edomites. This agrees very well not only with the account in 2-Samuel 10:10., to the effect that Abishai commanded a company in the war with the Syrians and Ammonites under the generalship of his brother Joab, but also with the heading to Psalm 60:1-12, in which it is stated that Joab returned after the defeat of Aram, and smote the Edomites in the valley of Salt, twelve thousand men; and with 1-Kings 11:15-16, in which we read that when David was in Edom, Joab, the captain of the host, came up to bury the slain, and smote every male in Edom, and remained six months in Edom with all Israel, till he had cut off every male in Edom. From this casual but yet elaborate notice, we learn that the war with the Edomites was a very obstinate one, and was not terminated all at once. The difference as to the number slain, which is stated to have been 18,000 in the text before us and in the Chronicles, and 12,000 in the heading to Psalm 60:1-12, may be explained in a very simple manner, on the supposition that the reckonings made were only approximative, and yielded different results;
(Note: Michaelis adduces a case in point from the Seven Years' War. After the battle of Lissa, eight or twelve thousand men were reported to have been taken prisoners; but when they were all counted, including those who fell into the hands of the conquerors on the second, third, and fourth days of the flight, the number amounted to 22,000.)
and the fact that David is named as the victor in the verse before us, Joab in Psalm 60:1-12, and Abishai in the Chronicles, admits of a very easy explanation after what has just been observed. The Chronicles contain the most literal account. Abishai smote the Edomites as commander of the men engaged, Joab as commander-in-chief of the whole army, and David as king and supreme governor, of whom the writer of the Chronicles affirms, "The Lord helped David in all his undertakings." After the defeat of the Edomites, David placed garrisons in the land, and made all Edom subject to himself. 2-Samuel 8:15-18. David's Ministers. - To the account of David's wars and victories there is appended a list of his official attendants, which is introduced with a general remark as to the spirit of his government. As king over all Israel, David continued to execute right and justice.