And he consumed their days in vanity. As the Psalmist here speaks of the whole people, as if he had said, that all without exception were speedily consumed, from the least even to the greatest, this might with probability be referred to that most grievous punishment which was confirmed and ratified by the wrath of God -- that they should all perish in the wilderness with only two exceptions, Joshua and Caleb; because, when already near the land of Canaan, they had turned back. That vast multitude, therefore, after they had shut against themselves the door of entrance into the Holy Land, died in the wilderness during the course of forty years. Days are put in the first place, and then years; by which it is intimated, that the duration of their life was cut short by the curse of God, and that it was quite apparent that they failed in the midst of their course. Their days then were consumed in vanity; for they vanished away like smoke: and their years in haste, because they passed swiftly away like a stream. The word vhlh, behalah, here translated haste, is by some rendered terror. I would rather prefer reading tumult; for it is undoubtedly meant that their life was taken away, as when in a tumult any thing is taken by force. But I would not be disposed to change the word haste, which brings out the meaning more perspicuously. It was a display of righteous retribution, on account of their obstinacy, that their strength which made them proud, thus withered and vanished all on a sudden as a shadow.

Therefore their days did he consume in vanity - He suffered them to spend their days - the days of that entire generation - in vain and fruitless wanderings in the desert. Instead of leading them at once to the promised land, they were kept there to wear out their life in tedious monotony, accomplishing nothing - wandering from place to place - until all the generation that had come out of Egypt had died.
And their years in trouble - literally, "in terror." Amidst the troubles, the alarms, the terrors of a vast and frightful desert. Sin - rebellion against God - leads to a course of life, and a death, of which these gloomy, sad, and cheerless wanderings in the desert were a striking emblem.

Their days did he consume in vanity - By causing them to wander forty years in the wilderness, vainly expecting an end to their labor, and the enjoyment of the promised rest, which, by their rebellions, they had forfeited.

Therefore their days did he consume in vanity,.... They were not immediately cut off by the hand of God, though some were; but the greatest part spent their time, for about eight and thirty years together, in fruitless marches to and fro in the wilderness, and never entered into the land of Canaan, where they were gradually wasted and consumed, till at length all their carcasses fell in the wilderness; see Numbers 14:32, time spent in sin is all waste time, and is spent in vanity; let a man enjoy ever so much of worldly things, it is all vanity and vexation of spirit; if he does not get to heaven at last, his life here is lived in vain; it had been better if he had never been born:
and their years in trouble: or "in terror" (a) and consternation; through their enemies, who smote and discomfited them, Numbers 14:45, through the earth's opening and swallowing many of them up; through fire coming from heaven on some of them, and fiery serpents being sent among them all, Numbers 16:31. It is an awful consideration, and yet it is true, of some wicked men, though not all, that they have nothing but trouble here, by what their sins bring upon them, and hell at last. Kimchi renders the word here used "suddenly", and interprets it of the sudden death of the spies; so the Syriac and Arabic versions "swiftly", following the Vulgate Latin, which renders it "with haste".
(a) "in terrore", Montanus; "per consternationem aut terrorem", Gejerus; "in terrore et consternatione", Michaelis.

Though there were partial reformations after chastisement, and God, in pity, withdrew His hand for a time, yet their general conduct was rebellious, and He was thus provoked to waste and destroy them, by long and fruitless wandering in the desert.

Vanity - In tedious and fruitless marches hither and thither. Trouble - In manifold diseases, dangers, and perplexities.