When I looked for good - When I supposed that respect would be shown me; or when I looked forward to an honored old age. I expected to be made happy and prosperous through life, as the result of my uprightness and benevolence; but, instead of that, calamity came and swept all my comforts away. He experienced the instability which most people are called to experience, and the divine dealings with him showed that no reliance could be placed on confident plans of happiness in this life.

When I looked for good, then (r) evil came [unto me]: and when I waited for light, there came darkness.
(r) Instead of comforting they mocked me.

When I looked for good,.... As he thought he might reasonably expect it, since he had shown such a sympathizing spirit to persons in trouble, and such pity and mercy to the poor: in the time of his prosperity, he looked for a continuance of the good things he enjoyed, and expected to have had them for many years to come, and to have died in the possession of them, Job 29:18; and even in his adversity, though he had received evil things at the hand of God, which he took patiently; yet at first he did not think they would always continue, but that there would be a turn of affairs, and he should again receive good at his hands; and he had been looking for it, as good men have reason to expect it; since God is good and does good, and especially to his own people, and has laid up goodness for them that fear him, and such an one Job was; and has promised good things unto them, both temporal and spiritual; for godliness and godly men have the promise of this life, and of that which is to come: but Job was disappointed in his expectation; for, says he,
then evil came unto me, the evil of affliction, one upon the back of another, even when in the height of his prosperity; and since repeated evil, new afflictions, came upon him by the appointment, order, and direction of God:
and when I waited for light; for the light of outward prosperity, such as he had formerly enjoyed; and for the light of God's countenance, which he most earnestly sought after, and longed for, and was in a waiting posture for it, as good men have reason to be; since light is sown for them in the purposes and decrees of God, in his counsel and covenant, in his Gospel, and the promises of it; and therefore should wait for the springing of it up, as the husbandman does for the springing up of the corn sown in the earth, and lying under the clods; and seeing that to the upright there arises light in darkness; and though God hides his face from them, for a moment, he will have mercy on them, and therefore should wait his time to be gracious to them; but Job had waited long, and, as he thought, to no purpose: for
there came darkness; the darkness of adversity, still thicker and darker, and no appearance of spiritual light and favour, or any discoveries of the love of God to him, or enjoyment of his presence; see Jeremiah 8:15.

I may be allowed to crave help, seeing that, "when I looked for good (on account of my piety and charity), yet evil," &c.
light-- (Job 22:28).

Upon me - Yet trouble came upon myself, when I expected it not.